okumin commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2002709112
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -5839,13 +5842,33 @@ public HiveMetaHook getHook(
}
};
+ if ("rest".equals(conf.get("metastore.type", "hms"))) {
+ return getHiveIcebergRESTCatalog(conf, hookLoader);
+ }
+
if (conf.getBoolVar(ConfVars.METASTORE_FASTPATH)) {
return new SessionHiveMetaStoreClient(conf, hookLoader, allowEmbedded);
Review Comment:
Just a note. `SessionHiveMetaStoreClient` has critical traits to achieve
some features, e.g., temporary tables. My question: Do we want to include those
capabilities when integrating with an Iceberg REST Catalog, or do we have valid
reasons why we don't need to support them?
IMetaStoreClient might not be a good place to override if we need them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
