dengzhhu653 commented on code in PR #5661:
URL: https://github.com/apache/hive/pull/5661#discussion_r1990926985
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -90,7 +94,42 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
config.addDataSourceProperty(kv.getKey(), kv.getValue());
}
- return new HikariDataSource(initMetrics(config));
+ return new HikariDataSource(initMetrics(config)) {
+ @Override
+ public Connection getConnection() throws SQLException {
Review Comment:
updates: My approach still has a critical problem, the DataNucleus ID
generator still holds the keys even when the connection rollback, this will
cause ID conflict if multiple HMS here in the backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
