deniskuzZ commented on code in PR #5699:
URL: https://github.com/apache/hive/pull/5699#discussion_r2005666593
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -643,7 +639,7 @@ private static ThriftServer startBinaryMetastore(int port,
HadoopThriftAuthBridg
return thread;
});
- TThreadPoolServer.Args args = new TThreadPoolServer.Args(serverSocket)
+ TThreadPoolServer.Args args = new TThreadPoolServer.Args(new
MetastoreTServerSocket(serverSocket, conf))
Review Comment:
since we do a minor refactor here, could we also extract and
rename`HiveMetastoreCli` -> `HiveMetaStoreCli` + remove public modifiers from
`ThriftServer`
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -643,7 +639,7 @@ private static ThriftServer startBinaryMetastore(int port,
HadoopThriftAuthBridg
return thread;
});
- TThreadPoolServer.Args args = new TThreadPoolServer.Args(serverSocket)
+ TThreadPoolServer.Args args = new TThreadPoolServer.Args(new
MetastoreTServerSocket(serverSocket, conf))
Review Comment:
since we do a minor refactor here, could we also extract and
rename`HiveMetastoreCli` -> `HiveMetaStoreCli` + remove public modifiers from
`ThriftServer` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
