dengzhhu653 commented on code in PR #5694:
URL: https://github.com/apache/hive/pull/5694#discussion_r2015156944


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -11322,6 +11322,16 @@ public NotificationEventResponse 
getNextNotification(NotificationEventRequest rq
         filterBuilder.setLength(filterBuilder.length() - 4); // remove the 
last " || "
         filterBuilder.append(") ");
       }
+      if (rqst.isSetEventTypeList()) {
+        filterBuilder.append(" && (");
+        for (String eventType : rqst.getEventTypeList()) {

Review Comment:
   nit: leave it to you, can we use `rqst.contains(eventType)` to the 
`filterBuilder`?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to