kokila-19 commented on code in PR #5745:
URL: https://github.com/apache/hive/pull/5745#discussion_r2026894240
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -3342,8 +3342,8 @@ public List<String> listPartitionNames(final String
catName, final String dbName
final boolean isEmptyFilter = exprBytes.length == 1 && exprBytes[0] == -1;
ExpressionTree tmp = null;
if (!isEmptyFilter) {
- tmp = PartFilterExprUtil.makeExpressionTree(expressionProxy, exprBytes,
- getDefaultPartitionName(defaultPartName), conf);
+ String exprString =
PartFilterExprUtil.getExpressionString(expressionProxy, exprBytes,
getDefaultPartitionName(defaultPartName), conf);
+ ExpressionTree exprTree = ExpressionTree.fromString(exprString);
}
final ExpressionTree exprTree = tmp;
Review Comment:
you can remove this as well as it is used further down in
**final ExpressionTree exprTree = exprString.isEmpty() ?
ExpressionTree.EMPTY_TREE : ExpressionTree.fromString(exprString);**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
