deniskuzZ commented on code in PR #5621:
URL: https://github.com/apache/hive/pull/5621#discussion_r2037280470
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionService.java:
##########
@@ -63,6 +63,11 @@ public Boolean compact(Table table, CompactionInfo ci)
throws Exception {
return false;
}
+ if (ci.type == CompactionType.SMART_OPTIMIZE) {
+ ci.type = compactionEvaluator.determineCompactionType();
+ msc.updateCompactionType(CompactionInfo.compactionInfoToStruct(ci));
Review Comment:
Could we avoid doing an extra HMS call and update the type together with the
status in `CompactFunction`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
