aturoczy commented on code in PR #5744:
URL: https://github.com/apache/hive/pull/5744#discussion_r2037799629
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java:
##########
@@ -361,8 +361,8 @@ public static boolean isCreateOperation(DDLOperation<?>
ddlOperation) {
}
private static String getMetricStageName(String stageName,
ReplicationMetricCollector metricCollector) {
- if( stageName == "REPL_DUMP" || stageName == "REPL_LOAD" || stageName ==
"ATLAS_DUMP" || stageName == "ATLAS_LOAD"
- || stageName == "RANGER_DUMP" || stageName == "RANGER_LOAD" ||
stageName == "RANGER_DENY"){
+ if( "REPL_DUMP".equals(stageName) || "REPL_LOAD".equals(stageName) ||
"ATLAS_DUMP".equals(stageName) || "ATLAS_LOAD".equals(stageName)
Review Comment:
I do not have to much sentiment if the string is equals or ==. Both are
acceptable. I would chime @deniskuzZ and @ayushtkn to tell which is the most
commonly used style in Hive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
