deniskuzZ commented on code in PR #5621:
URL: https://github.com/apache/hive/pull/5621#discussion_r2042213284
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionService.java:
##########
@@ -63,6 +59,15 @@ public Boolean compact(Table table, CompactionInfo ci)
throws Exception {
return false;
}
+ if (ci.type == CompactionType.SMART_OPTIMIZE) {
+ ci.type = compactionEvaluator.determineCompactionType();
Review Comment:
Can we create a local var `CompactionType type =
ompactionEvaluator.determineCompactionType()` and assign to `ci.type` after the
null check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
