zratkai commented on code in PR #5771:
URL: https://github.com/apache/hive/pull/5771#discussion_r2049218648
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreClientWithLocalCache.java:
##########
@@ -115,687 +46,15 @@ public HiveMetaStoreClientWithLocalCache(Configuration
conf, HiveMetaHookLoader
}
public HiveMetaStoreClientWithLocalCache(Configuration conf,
HiveMetaHookLoader hookLoader, Boolean allowEmbedded) throws MetaException {
- super(conf, hookLoader, allowEmbedded);
- }
-
- private static void initSizeEstimator() {
- sizeEstimator = new HashMap<>();
- IncrementalObjectSizeEstimator.createEstimators(CacheKey.class,
sizeEstimator);
- for (KeyType e : KeyType.values()) {
- for (Class<?> c : e.keyClasses) {
- IncrementalObjectSizeEstimator.createEstimators(c, sizeEstimator);
- }
- IncrementalObjectSizeEstimator.createEstimators(e.valueClass,
sizeEstimator);
- }
- }
-
- /**
- * KeyType is used to differentiate the request types. More types can be
added in future.
- * We added the unique classes that are part of the key for each request as
well as the
- * class of the value stored in the cache: At initialization time, they will
be registered
- * within the size estimator, which will be used to estimate the size of the
objects
- * within the cache.
- */
- public enum KeyType {
- // String <-- getConfigValueInternal(String name, String defaultValue)
- CONFIG_VALUE(String.class),
- // Database <-- getDatabaseInternal(GetDatabaseRequest request)
- DATABASE(Database.class, GetDatabaseRequest.class),
- // GetTableResult <-- getTableInternal(GetTableRequest req)
- TABLE(GetTableResult.class, GetTableRequest.class),
- // PrimaryKeysResponse <-- getPrimaryKeysInternal(PrimaryKeysRequest req)
- PRIMARY_KEYS(PrimaryKeysResponse.class, PrimaryKeysRequest.class),
- // ForeignKeysResponse <-- getForeignKeysInternal(ForeignKeysRequest req)
- FOREIGN_KEYS(ForeignKeysResponse.class, ForeignKeysRequest.class),
- // UniqueConstraintsResponse <--
getUniqueConstraintsInternal(UniqueConstraintsRequest req)
- UNIQUE_CONSTRAINTS(UniqueConstraintsResponse.class,
UniqueConstraintsRequest.class),
- // NotNullConstraintsResponse <--
getNotNullConstraintsInternal(NotNullConstraintsRequest req)
- NOT_NULL_CONSTRAINTS(NotNullConstraintsResponse.class,
NotNullConstraintsRequest.class),
- // TableStatsResult <-- getTableColumnStatisticsInternal(TableStatsRequest
rqst)
- // Stored individually as:
- // ColumnStatisticsObj <-- String dbName, String tblName, List<string>
colNames,
- // String catName, String validWriteIdList, String engine, long id,
(TableWatermark tw ?)
- TABLE_COLUMN_STATS(ColumnStatisticsObj.class, String.class, long.class,
TableWatermark.class),
- // AggrStats <-- getAggrStatsForInternal(PartitionsStatsRequest req),
(TableWatermark tw ?)
- AGGR_COL_STATS(AggrStats.class, PartitionsStatsRequest.class,
TableWatermark.class),
- // PartitionsByExprResult <--
getPartitionsByExprInternal(PartitionsByExprRequest req), (TableWatermark tw ?)
- PARTITIONS_BY_EXPR(PartitionsByExprResult.class,
PartitionsByExprRequest.class, TableWatermark.class),
- // PartitionsSpecByExprResult <--
getPartitionsSpecByExprInternal(PartitionsByExprRequest req), (TableWatermark
tw ?)
- PARTITIONS_SPEC_BY_EXPR(PartitionsSpecByExprResult.class,
PartitionsByExprRequest.class, TableWatermark.class),
- // PartitionNamesWrapper <-- listPartitionNamesInternal(String catName,
String dbName, String tableName,
- // int maxParts), (TableWatermark tw ?)
- LIST_PARTITIONS_ALL(PartitionNamesWrapper.class, String.class, int.class,
TableWatermark.class),
- // List<String> <-- listPartitionNamesInternal(String catName, String
dbName, String tableName,
- // List<String> partVals, int maxParts)
- LIST_PARTITIONS(String.class, int.class),
- // GetPartitionNamesPsResponse <--
listPartitionNamesRequestInternal(GetPartitionNamesPsRequest req)
- LIST_PARTITIONS_REQ(GetPartitionNamesPsResponse.class,
GetPartitionNamesPsRequest.class),
- // List<Partition> <- listPartitionsWithAuthInfoInternal(String catName,
String dbName, String tableName,
- // int maxParts, String userName, List<String> groupNames)
- LIST_PARTITIONS_AUTH_INFO_ALL(Partition.class, String.class, int.class),
- // List<Partition> <- listPartitionsWithAuthInfoInternal(String catName,
String dbName, String tableName,
- // List<String> partialPvals, int maxParts, String userName,
List<String> groupNames)
- LIST_PARTITIONS_AUTH_INFO(Partition.class, String.class, int.class),
- // GetPartitionsPsWithAuthResponse <-
listPartitionsWithAuthInfoRequestInternal(GetPartitionsPsWithAuthRequest req)
- LIST_PARTITIONS_AUTH_INFO_REQ(GetPartitionsPsWithAuthResponse.class,
GetPartitionsPsWithAuthRequest.class),
- // GetPartitionsByNamesResult <--
getPartitionsByNamesInternal(GetPartitionsByNamesRequest gpbnr)
- // Stored individually as:
- // Partition <-- String db_name, String tbl_name, List<String> partValues,
boolean get_col_stats,
- // List<String> processorCapabilities, String processorIdentifier,
String engine,
- // String validWriteIdList, (TableWatermark tw ?)
- PARTITIONS_BY_NAMES(Partition.class, String.class, boolean.class,
TableWatermark.class),
- // GetValidWriteIdsResponse <--
getValidWriteIdsInternal(GetValidWriteIdsRequest rqst)
- // Stored individually as:
- // TableValidWriteIds <-- String fullTableName, String validTxnList, long
writeId
- VALID_WRITE_IDS(TableValidWriteIds.class, String.class, long.class),
- // TableId <- String fullTableName
- TABLE_ID(Long.class, String.class);
-
- private final List<Class<?>> keyClasses;
- private final Class<?> valueClass;
-
- KeyType(Class<?> valueClass, Class<?>... keyClasses) {
- this.keyClasses =
Collections.unmodifiableList(Arrays.asList(keyClasses));
- this.valueClass = valueClass;
- }
- }
-
- /**
- * CacheKey objects are used as key for the cache.
- */
- public static class CacheKey{
- KeyType IDENTIFIER;
- List<Object> obj;
-
- public CacheKey(KeyType IDENTIFIER, Object... objs) {
- this.IDENTIFIER = IDENTIFIER;
- this.obj = Collections.unmodifiableList(Arrays.asList(objs));
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
- CacheKey cacheKey = (CacheKey) o;
- return IDENTIFIER == cacheKey.IDENTIFIER &&
- Objects.equals(obj, cacheKey.obj);
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(IDENTIFIER, obj);
- }
-
- @Override
- public String toString() {
- return "CacheKey {" + IDENTIFIER.name() + " @@ " + obj.toString() + "}";
- }
- }
-
- private static int getWeight(CacheKey key, Object val) {
- ObjectEstimator keySizeEstimator = sizeEstimator.get(key.getClass());
- ObjectEstimator valSizeEstimator =
sizeEstimator.get(key.IDENTIFIER.valueClass);
- int keySize = keySizeEstimator.estimate(key, sizeEstimator);
- int valSize = valSizeEstimator.estimate(val, sizeEstimator);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Cache entry weight - key: {}, value: {}, total: {}", keySize,
valSize, keySize + valSize);
- }
- return keySize + valSize;
- }
-
- /**
- * Initializes the cache
- */
- private static void initCache() {
- int initSize = 100;
- Caffeine<CacheKey, Object> cacheBuilder = Caffeine.newBuilder()
- .initialCapacity(initSize)
- .maximumWeight(maxSize)
- .weigher(HiveMetaStoreClientWithLocalCache::getWeight)
- .removalListener((key, val, cause) -> {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Caffeine - ({}, {}) was removed ({})", key, val, cause);
- }});
- if (recordStats) {
- cacheBuilder.recordStats();
- }
- mscLocalCache = cacheBuilder.build();
- cacheObjName = cacheBuilder.toString();
- }
-
- @Override
- protected GetTableResult getTableInternal(GetTableRequest req) throws
TException {
- if (isCacheEnabledAndInitialized()) {
- // table should be transactional to get responses from the cache
- TableWatermark watermark = new TableWatermark(
- req.getValidWriteIdList(), req.getId());
- if (watermark.isValid()) {
- CacheKey cacheKey = new CacheKey(KeyType.TABLE, req);
- GetTableResult r = (GetTableResult)
mscLocalCache.getIfPresent(cacheKey);
- if (r == null) {
- r = super.getTableInternal(req);
- mscLocalCache.put(cacheKey, r);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getTableInternal, dbName={},
tblName={}, columnStats={}",
- req.getDbName(), req.getTblName(), req.isGetColumnStats());
- }
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return r;
- }
- }
- return super.getTableInternal(req);
- }
-
- @Override
- protected PartitionsByExprResult
getPartitionsByExprInternal(PartitionsByExprRequest req) throws TException {
- if (isCacheEnabledAndInitialized()) {
- // table should be transactional to get responses from the cache
- TableWatermark watermark = new TableWatermark(
- req.getValidWriteIdList(), getTable(req.getDbName(),
req.getTblName()).getId());
- if (watermark.isValid()) {
- CacheKey cacheKey = new CacheKey(KeyType.PARTITIONS_BY_EXPR,
watermark, req);
- PartitionsByExprResult r = (PartitionsByExprResult)
mscLocalCache.getIfPresent(cacheKey);
- if (r == null) {
- r = super.getPartitionsByExprInternal(req);
- mscLocalCache.put(cacheKey, r);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getPartitionsByExprInternal,
dbName={}, tblName={}",
- req.getDbName(), req.getTblName());
- }
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return r;
- }
- }
-
- return super.getPartitionsByExprInternal(req);
- }
-
- @Override
- protected List<String> listPartitionNamesInternal(String catName, String
dbName, String tableName,
- int maxParts) throws TException {
- if (isCacheEnabledAndInitialized()) {
- TableWatermark watermark = new TableWatermark(
- getValidWriteIdList(dbName, tableName),
- getTable(dbName, tableName).getId());
- if (watermark.isValid()) {
- CacheKey cacheKey = new CacheKey(KeyType.LIST_PARTITIONS_ALL,
watermark,
- catName, dbName, tableName, maxParts);
- PartitionNamesWrapper r = (PartitionNamesWrapper)
mscLocalCache.getIfPresent(cacheKey);
- if (r == null) {
- r = new PartitionNamesWrapper(
- super.listPartitionNamesInternal(catName, dbName, tableName,
maxParts));
- mscLocalCache.put(cacheKey, r);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=listPartitionNamesInternal,
dbName={}, tblName={}",
- dbName, tableName);
- }
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return r.partitionNames;
- }
- }
- return super.listPartitionNamesInternal(catName, dbName, tableName,
maxParts);
- }
-
- /* This class is needed so the size estimator can work properly. */
- private static class PartitionNamesWrapper {
- private final List<String> partitionNames;
-
- private PartitionNamesWrapper(List<String> partitionNames) {
- this.partitionNames = partitionNames;
- }
- }
-
- @Override
- protected PartitionsSpecByExprResult
getPartitionsSpecByExprInternal(PartitionsByExprRequest req) throws TException {
- if (isCacheEnabledAndInitialized()) {
- // table should be transactional to get responses from the cache
- TableWatermark watermark = new TableWatermark(
- getValidWriteIdList(req.getDbName(), req.getTblName()),
- getTable(req.getDbName(), req.getTblName()).getId());
- if (watermark.isValid()) {
- CacheKey cacheKey = new CacheKey(KeyType.PARTITIONS_SPEC_BY_EXPR,
watermark, req);
- PartitionsSpecByExprResult r = (PartitionsSpecByExprResult)
mscLocalCache.getIfPresent(cacheKey);
- if (r == null) {
- r = super.getPartitionsSpecByExprInternal(req);
- mscLocalCache.put(cacheKey, r);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getPartitionsSpecByExprInternal,
dbName={}, tblName={}",
- req.getDbName(), req.getTblName());
- }
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return r;
- }
- }
-
- return super.getPartitionsSpecByExprInternal(req);
- }
-
- @Override
- protected TableStatsResult
getTableColumnStatisticsInternal(TableStatsRequest req) throws TException {
- if (isCacheEnabledAndInitialized()) {
- TableWatermark watermark = new TableWatermark(
- getValidWriteIdList(req.getDbName(), req.getTblName()),
- getTable(req.getDbName(), req.getTblName()).getId());
- if (watermark.isValid()) {
- CacheWrapper cache = new CacheWrapper(mscLocalCache);
- // 1) Retrieve from the cache those ids present, gather the rest
- Pair<List<ColumnStatisticsObj>, List<String>> p =
getTableColumnStatisticsCache(
- cache, req, watermark);
- List<String> colStatsMissing = p.getRight();
- List<ColumnStatisticsObj> colStats = p.getLeft();
- // 2) If they were all present in the cache, return
- if (colStatsMissing.isEmpty()) {
- return new TableStatsResult(colStats);
- }
- // 3) If they were not, gather the remaining
- TableStatsRequest newRqst = new TableStatsRequest(req);
- newRqst.setColNames(colStatsMissing);
- TableStatsResult r = super.getTableColumnStatisticsInternal(newRqst);
- // 4) Populate the cache
- List<ColumnStatisticsObj> newColStats = loadTableColumnStatisticsCache(
- cache, r, req, watermark);
- // 5) Sort result (in case there is any assumption) and return
- TableStatsResult result = computeTableColumnStatisticsFinal(req,
colStats, newColStats);
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return result;
- }
- }
-
- return super.getTableColumnStatisticsInternal(req);
- }
-
- @Override
- protected AggrStats getAggrStatsForInternal(PartitionsStatsRequest req)
throws TException {
- if (isCacheEnabledAndInitialized()) {
- TableWatermark watermark = new TableWatermark(
- req.getValidWriteIdList(), getTable(req.getDbName(),
req.getTblName()).getId());
- if (watermark.isValid()) {
- CacheKey cacheKey = new CacheKey(KeyType.AGGR_COL_STATS, watermark,
req);
- AggrStats r = (AggrStats) mscLocalCache.getIfPresent(cacheKey);
- if (r == null) {
- r = super.getAggrStatsForInternal(req);
- mscLocalCache.put(cacheKey, r);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getAggrStatsForInternal, dbName={},
tblName={}, partNames={}",
- req.getDbName(), req.getTblName(), req.getPartNames());
- }
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return r;
- }
- }
-
- return super.getAggrStatsForInternal(req);
- }
-
- @Override
- protected GetPartitionsByNamesResult
getPartitionsByNamesInternal(GetPartitionsByNamesRequest rqst) throws
TException {
- if (isCacheEnabledAndInitialized()) {
- String dbName = parseDbName(rqst.getDb_name(), conf)[1];
- TableWatermark watermark = new TableWatermark(
- rqst.getValidWriteIdList(), getTable(dbName,
rqst.getTbl_name()).getId());
- if (watermark.isValid()) {
- CacheWrapper cache = new CacheWrapper(mscLocalCache);
- // 1) Retrieve from the cache those ids present, gather the rest
- Pair<List<Partition>, List<String>> p = getPartitionsByNamesCache(
- cache, rqst, watermark);
- List<String> partitionsMissing = p.getRight();
- List<Partition> partitions = p.getLeft();
- // 2) If they were all present in the cache, return
- if (partitionsMissing.isEmpty()) {
- return new GetPartitionsByNamesResult(partitions);
- }
- // 3) If they were not, gather the remaining
- GetPartitionsByNamesRequest newRqst = new
GetPartitionsByNamesRequest(rqst);
- newRqst.setNames(partitionsMissing);
- GetPartitionsByNamesResult r =
super.getPartitionsByNamesInternal(newRqst);
- // 4) Populate the cache
- List<Partition> newPartitions = loadPartitionsByNamesCache(
- cache, r, rqst, watermark);
- // 5) Sort result (in case there is any assumption) and return
- GetPartitionsByNamesResult result =
computePartitionsByNamesFinal(rqst, partitions, newPartitions);
-
- if (LOG.isDebugEnabled() && recordStats) {
- LOG.debug(cacheObjName + ": " + mscLocalCache.stats().toString());
- }
-
- return result;
- }
- }
-
- return super.getPartitionsByNamesInternal(rqst);
- }
-
-
- /**
- * Checks if cache is enabled and initialized
- *
- * @return boolean
- */
- private boolean isCacheEnabledAndInitialized() {
- // Do not use the cache if session level query cache is also disabled
- // Both caches can be used only at compilation time because execution may
change
- // DB objects (Tables, Partition metadata objects) and cache entries may
already invalid
- SessionState sessionState = SessionState.get();
- if (sessionState == null || sessionState.getQueryCache(getQueryId()) ==
null) {
- return false;
- }
-
- return INITIALIZED.get();
- }
-
- protected String getQueryId() {
- try {
- return Hive.get().getConf().get(HiveConf.ConfVars.HIVE_QUERY_ID.varname);
- } catch (HiveException e) {
- LOG.error("Error getting query id. Query level and Global HMS caching
will be disabled", e);
- return null;
- }
- }
-
- protected final Pair<List<ColumnStatisticsObj>, List<String>>
getTableColumnStatisticsCache(CacheI cache,
- TableStatsRequest rqst, TableWatermark watermark) {
- List<String> colStatsMissing = new ArrayList<>();
- List<ColumnStatisticsObj> colStats = new ArrayList<>();
- for (String colName : rqst.getColNames()) {
- CacheKey cacheKey = new CacheKey(KeyType.TABLE_COLUMN_STATS, watermark,
- rqst.getDbName(), rqst.getTblName(), colName,
- rqst.getCatName(), rqst.getValidWriteIdList(),
- rqst.getEngine(), rqst.getId());
- ColumnStatisticsObj v = (ColumnStatisticsObj) cache.get(cacheKey);
- if (v == null) {
- colStatsMissing.add(colName);
- } else {
- if (watermark == null) {
- LOG.debug(
- "Query level HMS cache: method=getTableColumnStatisticsInternal,
dbName={}, tblName={}, colName={}",
- rqst.getDbName(), rqst.getTblName(), colName);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getTableColumnStatisticsInternal,
dbName={}, tblName={}, colName={}",
- rqst.getDbName(), rqst.getTblName(), colName);
- }
- colStats.add(v);
- }
- }
- return Pair.of(colStats, colStatsMissing);
- }
-
- protected final List<ColumnStatisticsObj>
loadTableColumnStatisticsCache(CacheI cache,
- TableStatsResult r, TableStatsRequest rqst, TableWatermark watermark) {
- List<ColumnStatisticsObj> newColStats = new ArrayList<>();
- for (ColumnStatisticsObj colStat : r.getTableStats()) {
- CacheKey cacheKey = new CacheKey(KeyType.TABLE_COLUMN_STATS, watermark,
- rqst.getDbName(), rqst.getTblName(), colStat.getColName(),
- rqst.getCatName(), rqst.getValidWriteIdList(),
- rqst.getEngine(), rqst.getId());
- cache.put(cacheKey, colStat);
- newColStats.add(colStat);
- }
- return newColStats;
- }
-
- protected final TableStatsResult
computeTableColumnStatisticsFinal(TableStatsRequest rqst,
- List<ColumnStatisticsObj> colStats, List<ColumnStatisticsObj>
newColStats) {
- List<ColumnStatisticsObj> result = new ArrayList<>();
- int i = 0, j = 0;
- for (String colName : rqst.getColNames()) {
- if (i >= colStats.size() || j >= newColStats.size()) {
- break;
- }
- if (colStats.get(i).getColName().equals(colName)) {
- result.add(colStats.get(i));
- i++;
- } else if (newColStats.get(j).getColName().equals(colName)) {
- result.add(newColStats.get(j));
- j++;
- }
- }
- while (i < colStats.size()) {
- result.add(colStats.get(i));
- i++;
- }
- while (j < newColStats.size()) {
- result.add(newColStats.get(j));
- j++;
- }
- return new TableStatsResult(result);
- }
-
-
- protected final Pair<List<Partition>, List<String>>
getPartitionsByNamesCache(CacheI cache,
- GetPartitionsByNamesRequest rqst, TableWatermark watermark) throws
MetaException {
- List<String> partitionsMissing = new ArrayList<>();
- List<Partition> partitions = new ArrayList<>();
- for (String partitionName : rqst.getNames()) {
- CacheKey cacheKey = new CacheKey(KeyType.PARTITIONS_BY_NAMES, watermark,
- rqst.getDb_name(), rqst.getTbl_name(),
Warehouse.getPartValuesFromPartName(partitionName),
- rqst.isGet_col_stats(), rqst.getProcessorCapabilities(),
rqst.getProcessorIdentifier(),
- rqst.getEngine(), rqst.getValidWriteIdList());
- Partition v = (Partition) cache.get(cacheKey);
- if (v == null) {
- partitionsMissing.add(partitionName);
- } else {
- if (watermark == null) {
- LOG.debug(
- "Query level HMS cache: method=getPartitionsByNamesInternal,
dbName={}, tblName={}, partitionName={}",
- rqst.getDb_name(), rqst.getTbl_name(), partitionName);
- } else {
- LOG.debug(
- "HS2 level HMS cache: method=getPartitionsByNamesInternal,
dbName={}, tblName={}, partitionName={}",
- rqst.getDb_name(), rqst.getTbl_name(), partitionName);
- }
- partitions.add(v);
- }
- }
- return Pair.of(partitions, partitionsMissing);
- }
-
- protected final List<Partition> loadPartitionsByNamesCache(CacheI cache,
- GetPartitionsByNamesResult r, GetPartitionsByNamesRequest rqst,
TableWatermark watermark) {
- List<Partition> newPartitions = new ArrayList<>();
- for (Partition partition : r.getPartitions()) {
- CacheKey cacheKey = new CacheKey(KeyType.PARTITIONS_BY_NAMES, watermark,
- rqst.getDb_name(), rqst.getTbl_name(), partition.getValues(),
- rqst.isGet_col_stats(), rqst.getProcessorCapabilities(),
rqst.getProcessorIdentifier(),
- rqst.getEngine(), rqst.getValidWriteIdList());
- cache.put(cacheKey, partition);
- newPartitions.add(partition);
- }
- return newPartitions;
+ super(createUnderlyingClient(conf, hookLoader, allowEmbedded));
}
- protected final GetPartitionsByNamesResult
computePartitionsByNamesFinal(GetPartitionsByNamesRequest rqst,
- List<Partition> partitions, List<Partition> newPartitions) throws
MetaException {
- List<Partition> result = new ArrayList<>();
- int i = 0, j = 0;
- for (String partitionName : rqst.getNames()) {
- if (i >= partitions.size() || j >= newPartitions.size()) {
- break;
- }
- List<String> pv = Warehouse.getPartValuesFromPartName(partitionName);
- if (partitions.get(i).getValues().equals(pv)) {
- result.add(partitions.get(i));
- i++;
- } else if (newPartitions.get(j).getValues().equals(pv)) {
- result.add(newPartitions.get(j));
- j++;
- }
- }
- while (i < partitions.size()) {
- result.add(partitions.get(i));
- i++;
- }
- while (j < newPartitions.size()) {
- result.add(newPartitions.get(j));
- j++;
- }
- return new GetPartitionsByNamesResult(result);
+ private static IMetaStoreClient createUnderlyingClient(Configuration conf,
HiveMetaHookLoader hookLoader,
+ Boolean allowEmbedded) throws MetaException {
+ IMetaStoreClient thriftClient = new ThriftHiveMetaStoreClient(conf,
allowEmbedded);
Review Comment:
If we have ThriftHiveMetaStoreClient here it means we can not reuse the
functionality of this class with other than ThriftHiveMetaStoreClient e.g.
RESTClient for Iceberg REST catalog can not reuse the functionality of
ql/HiveMetaStoreClientWithLocalCache. This should be an input as delegate I
guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
