kasakrisz commented on code in PR #5807:
URL: https://github.com/apache/hive/pull/5807#discussion_r2084404904
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/StatsUpdater.java:
##########
@@ -54,15 +57,13 @@ public final class StatsUpdater {
*/
public void gatherStats(CompactionInfo ci, HiveConf hiveConf,
String userName, String compactionQueueName,
- IMetaStoreClient msc) {
+ IMetaStoreClient msc, Map<String, String>
tableProperties) {
try {
if (msc == null) {
throw new IllegalArgumentException("Metastore client is
missing");
}
- HiveConf conf = new HiveConf(hiveConf);
- //so that Driver doesn't think it's already in a transaction
- conf.unset(ValidTxnList.VALID_TXNS_KEY);
+ HiveConf conf = createConfiguration(hiveConf, compactionQueueName,
tableProperties, ci.getProperties());
Review Comment:
I moved `overrideConfProps` to `CompactorUtils` and using this method in
`StatsUpdater` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
