wecharyu commented on code in PR #5790:
URL: https://github.com/apache/hive/pull/5790#discussion_r2085079704
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -10214,6 +10214,8 @@ public boolean deletePartitionColumnStatistics(String
catName, String dbName, St
}
dbName = org.apache.commons.lang3.StringUtils.defaultString(dbName,
Warehouse.DEFAULT_DATABASE_NAME);
catName = normalizeIdentifier(catName);
+ long tableID = directSql.getTableId(dbName, tableName);
+ directSql.deleteColumnStatsState(tableID);
Review Comment:
what if direct sql is not allowed? can we move it to `getSqlResult()`?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -7460,6 +7467,8 @@ public boolean
delete_column_statistics_req(DeleteColumnStatisticsRequest req) t
.collect(Collectors.toList()) : colNames) {
for (String partName : partNames) {
List<String> partVals = getPartValsFromName(table, partName);
+ Partition partition =
rawStore.getPartition(parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tableName,
partVals);
+ Map<String, String> partParams = partition.getParameters();
Review Comment:
The `partParams` seems no used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
