wecharyu commented on code in PR #5816:
URL: https://github.com/apache/hive/pull/5816#discussion_r2099766690
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java:
##########
@@ -97,17 +93,10 @@
*/
public final class PlanUtils {
- protected static final Logger LOG =
LoggerFactory.getLogger("org.apache.hadoop.hive.ql.plan.PlanUtils");
+ private static final Logger LOG =
LoggerFactory.getLogger("org.apache.hadoop.hive.ql.plan.PlanUtils");
Review Comment:
```suggestion
private static final Logger LOG = LoggerFactory.getLogger(PlanUtils.class);
```
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLDescWithTableProperties.java:
##########
@@ -30,7 +32,13 @@
public abstract class DDLDescWithTableProperties implements DDLDesc {
protected List<String> partColNames;
protected Map<String, String> tblProps;
+ private List<FieldSchema> partCols;
Review Comment:
The`comment`, `ifNotExists` and `schema/cols` are also common fields, can
we put them here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
