SourabhBadhya commented on code in PR #5789:
URL: https://github.com/apache/hive/pull/5789#discussion_r2100616559
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -897,22 +896,21 @@ public List<FileStatus> getOutputFiles(List<JobContext>
jobContexts) throws IOEx
* @return Returns the list of file statuses of the output files in the
jobContexts
* @throws IOException Throws IOException
*/
- public List<ContentFile> getOutputContentFiles(List<JobContext> jobContexts)
throws IOException {
+ public List<ContentFile<?>> getOutputContentFiles(List<JobContext>
jobContexts) throws IOException {
Multimap<OutputTable, JobContext> outputs = collectOutputs(jobContexts);
JobConf jobConf = jobContexts.get(0).getJobConf();
ExecutorService fileExecutor = fileExecutor(jobConf);
ExecutorService tableExecutor = tableExecutor(jobConf,
outputs.keySet().size());
- Collection<ContentFile> files = new ConcurrentLinkedQueue<>();
+ Collection<ContentFile<?>> files = new ConcurrentLinkedQueue<>();
try {
Tasks.foreach(outputs.keySet())
.suppressFailureWhenFinished()
.executeWith(tableExecutor)
.onFailure((output, exc) -> LOG.warn("Failed to retrieve merge input
file for the table {}", output, exc))
.run(output -> {
for (JobContext jobContext : outputs.get(output)) {
- LOG.info("Cleaning job for jobID: {}, table: {}",
jobContext.getJobID(), output);
Review Comment:
Any reason for removing this log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
