zabetak opened a new pull request, #5829: URL: https://github.com/apache/hive/pull/5829
### What changes were proposed in this pull request and why? 1. Upgrade to datanucleus-rdbms version 5.2.13 that contains the fix for the connection leak (https://github.com/datanucleus/datanucleus-rdbms/issues/501). 2. Add a test case reproducing the connection leak by introducing random failures on commit using the jdbc-faulty project. ### Does this PR introduce _any_ user-facing change? Yes, fixes the leak. ### How was this patch tested? ``` mvn clean test -Dtest=TestObjectStoreSecondaryPoolLeak -Dtest.groups= ``` #### Before the datanucleus upgrade The test fails with the following error: ``` [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 40.73 s <<< FAILURE! -- in org.apache.hadoop.hive.metastore.TestObjectStoreSecondaryPoolLeak [ERROR] org.apache.hadoop.hive.metastore.TestObjectStoreSecondaryPoolLeak.testCreateTableWithRandomTimeoutOnCommit -- Time elapsed: 30.23 s <<< FAILURE! org.opentest4j.AssertionFailedError: Connection leak during creation of table_28 at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:42) at org.junit.jupiter.api.Assertions.fail(Assertions.java:150) at org.apache.hadoop.hive.metastore.TestObjectStoreSecondaryPoolLeak.testCreateTableWithRandomTimeoutOnCommit(TestObjectStoreSecondaryPoolLeak.java:103) ... ``` #### After the datanucleus upgrade The test passes successfully in ~40 seconds. ``` [INFO] Running org.apache.hadoop.hive.metastore.TestObjectStoreSecondaryPoolLeak [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.89 s -- in org.apache.hadoop.hive.metastore.TestObjectStoreSecondaryPoolLeak [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
