deniskuzZ commented on code in PR #4446:
URL: https://github.com/apache/hive/pull/4446#discussion_r2127086929


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -347,9 +350,8 @@ public void configureJobConf(TableDesc tableDesc, JobConf 
jobConf) {
       if (isMergeTaskEnabled) {
         HiveCustomStorageHandlerUtils.setMergeTaskEnabled(jobConf, tableName, 
true);
       }
-      String tables = jobConf.get(InputFormatConfig.OUTPUT_TABLES);
-      tables = tables == null ? tableName : tables + TABLE_NAME_SEPARATOR + 
tableName;
-      jobConf.set(InputFormatConfig.OUTPUT_TABLES, tables);
+      String existingOutputTables = 
jobConf.get(InputFormatConfig.OUTPUT_TABLES);
+      jobConf.set(InputFormatConfig.OUTPUT_TABLES, getOutputTables(tableName, 
existingOutputTables));

Review Comment:
   maybe
   ````
   String tables = getOutputTables(tableName, jobConf);
   jobConf.set(InputFormatConfig.OUTPUT_TABLES, tables);
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to