kokila-19 commented on code in PR #5852:
URL: https://github.com/apache/hive/pull/5852#discussion_r2139807918
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -1002,8 +1002,37 @@ public boolean dropDatabase(String catName, String
dbname)
@Override
public List<String> getDatabases(String catName, String pattern) throws
MetaException {
+ catName = normalizeIdentifier(catName);
+ try {
+ return getDatabasesInternal(catName, pattern);
+ } catch (NoSuchObjectException e) {
+ throw new MetaException(ExceptionUtils.getStackTrace(e));
+ }
+ }
+
+ private List<String> getDatabasesInternal(String catName, String pattern)
+ throws MetaException, NoSuchObjectException {
+ return new GetHelper<List<String>>(catName, null, pattern, true, true) {
+ @Override
+ protected String describeResult() {
+ return "List of databases matching pattern";
+ }
+
+ @Override
+ protected List<String> getSqlResult(GetHelper<List<String>> ctx) throws
MetaException {
+ return directSql.getDatabases(catName, pattern);
+ }
+
+ @Override
+ protected List<String> getJdoResult(GetHelper<List<String>> ctx) throws
MetaException {
+ return getGetDatabasesViaJdo(catName, pattern);
Review Comment:
getGetDatabasesViaJdo has redundant get in the method name which can be
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
