deniskuzZ commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2142796211
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -140,8 +156,9 @@ void alterCatalog(String catalogName, Catalog newCatalog)
* @throws MetaException something went wrong, usually in the database.
* @throws TException general thrift exception.
*/
- void dropCatalog(String catName)
- throws NoSuchObjectException, InvalidOperationException, MetaException,
TException;
+ default void dropCatalog(String catName)
Review Comment:
should throw UnsupportedOperationException
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -150,7 +167,8 @@ void dropCatalog(String catName)
* @param ifExists if true, do not throw an error if the catalog does not
exist.
* @throws TException general thrift exception.
*/
- void dropCatalog(String catName, boolean ifExists) throws TException;
+ default void dropCatalog(String catName, boolean ifExists) throws TException
{
Review Comment:
should throw UnsupportedOperationException
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
