dengzhhu653 commented on code in PR #5628:
URL: https://github.com/apache/hive/pull/5628#discussion_r2146697959
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -815,26 +855,30 @@ List<Table> getTables(String catName, String dbName,
List<String> tableNames, Ge
* @throws MetaException
* Any other errors
*/
- List<Table> getTableObjectsByName(String catName, String dbName,
List<String> tableNames)
- throws MetaException, InvalidOperationException, UnknownDBException,
TException;
+ default List<Table> getTableObjectsByName(String catName, String dbName,
List<String> tableNames)
+ throws MetaException, InvalidOperationException, UnknownDBException,
TException{
+ return Collections.emptyList();
+ }
/**
* Returns the invalidation information for the materialized views given as
input.
*/
- Materialization getMaterializationInvalidationInfo(CreationMetadata cm,
String validTxnList)
- throws MetaException, InvalidOperationException, UnknownDBException,
TException;
+ default Materialization getMaterializationInvalidationInfo(CreationMetadata
cm, String validTxnList)
+ throws MetaException, InvalidOperationException, UnknownDBException,
TException{
+ return new Materialization();
+ }
/**
* Updates the creation metadata for the materialized view.
*/
- void updateCreationMetadata(String dbName, String tableName,
CreationMetadata cm)
- throws MetaException, TException;
+ default void updateCreationMetadata(String dbName, String tableName,
CreationMetadata cm)
+ throws MetaException, TException{}
/**
* Updates the creation metadata for the materialized view.
*/
- void updateCreationMetadata(String catName, String dbName, String tableName,
CreationMetadata cm)
- throws MetaException, TException;
+ default void updateCreationMetadata(String catName, String dbName, String
tableName, CreationMetadata cm)
Review Comment:
Compared to dropping the deprecated API, I'm wondering if we can introduce a
new interface, such as `IMetastoreClientV2`, this class is only for taking care
of the lifecycle of the thrift connection. For any table operation, a user can
do like this: `TableMetaOperation.of(IMetastoreClientV2, default catalog,
configuration).create/drop/getTable(...)`, this is outside of this PR's scope
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
