Paramvir109 commented on code in PR #5845:
URL: https://github.com/apache/hive/pull/5845#discussion_r2147016238
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java:
##########
@@ -307,9 +320,19 @@ public void load(MapJoinTableContainer[] mapJoinTables,
LOG.info("Finished loading the queue for input: {} waiting {} minutes
for TPool shutdown", inputName, 2);
addQueueDoneSentinel();
loadExecService.shutdown();
-
- if (!loadExecService.awaitTermination(2, TimeUnit.MINUTES)) {
+ try {
+ CompletableFuture.allOf(loaderTasks.toArray(new
CompletableFuture[0]))
+ .get(2, TimeUnit.MINUTES);
+ } catch (TimeoutException e) {
throw new HiveException("Failed to complete the hash table loader.
Loading timed out.");
+ } catch (ExecutionException e) {
+ throw new HiveException("One of the loader threads failed",
e.getCause());
+ } catch (InterruptedException e) {
Review Comment:
Ack, I'll update in the next revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
