okumin commented on code in PR #5870:
URL: https://github.com/apache/hive/pull/5870#discussion_r2147013121
##########
standalone-metastore/metastore-rest-catalog/src/test/java/org/apache/iceberg/rest/TestHMSCatalogAuthNone.java:
##########
@@ -36,45 +39,41 @@
import org.apache.iceberg.rest.requests.CreateTableRequest;
import org.apache.iceberg.rest.requests.RenameTableRequest;
import org.apache.iceberg.types.Types;
-import static org.apache.iceberg.types.Types.NestedField.required;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
-public class TestHMSCatalog extends HMSTestBase {
- public TestHMSCatalog() {
- super();
- }
-
+public class TestHMSCatalogAuthNone extends HMSTestBase {
@Before
@Override
public void setUp() throws Exception {
- super.setUp();
+ conf = MetastoreConf.newMetastoreConf();
+ MetastoreConf.setVar(conf,
MetastoreConf.ConfVars.ICEBERG_CATALOG_SERVLET_AUTH, "none");
+ super.setUp();
}
-
+
@After
@Override
public void tearDown() throws Exception {
- super.tearDown();
+ super.tearDown();
}
@Test
public void testCreateNamespaceHttp() throws Exception {
String ns = "nstesthttp";
// list namespaces
URL url = new URL("http://hive@localhost:"; + catalogPort +
"/"+catalogPath+"/v1/namespaces");
- String jwt = generateJWT();
// check namespaces list (ie 0)
- Object response = clientCall(jwt, url, "GET", null);
+ Object response = clientCall(url, "GET", Collections.emptyMap(), null);
Review Comment:
Yes. I'm thinking of replacing all tests with the compatibility kit before
applying cosmetic changes on this test cases. Basically, the current coverage
is too small.
https://issues.apache.org/jira/browse/HIVE-29019
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1867,7 +1867,7 @@ public enum ConfVars {
" positive value will be used as-is."
),
ICEBERG_CATALOG_SERVLET_AUTH("metastore.iceberg.catalog.servlet.auth",
- "hive.metastore.iceberg.catalog.servlet.auth", "jwt", new
StringSetValidator("simple", "jwt"),
+ "hive.metastore.iceberg.catalog.servlet.auth", "jwt", new
StringSetValidator("none", "simple", "jwt"),
Review Comment:
OK. I am considering if we should support SIMPLE and JWT. They are likely
inherited from `hive.metastore.properties.servlet.auth`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
