zabetak opened a new pull request, #5879: URL: https://github.com/apache/hive/pull/5879
### What changes were proposed in this pull request? 1. Change `trimFields(JdbcRel)` to `trimFields(JdbcSort)` to break the ambiguity and avoid the error. 2. Make `CalcitePlanner#HIVE_REL_NODE_CLASSES` public mainly to facilitate testing. In fact, it makes sense to expose this information somewhere so why not in CalcitePlanner. ### Why are the changes needed? Avoid the ambiguity exception during HS2 startup. For more details see commit message or HIVE-28667. ### Does this PR introduce _any_ user-facing change? No. There is no change in behavior since anyways the trimmer cannot be called with a JdbcSort operator. ### How was this patch tested? ``` mvn test -Dtest=TestHiveRelFieldTrimmer -pl ql mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex=".*jdbc.*" -pl itests/qtest -Pitests ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
