deniskuzZ commented on code in PR #5624: URL: https://github.com/apache/hive/pull/5624#discussion_r2159993872
########## ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringSubstrColStart.java: ########## @@ -75,7 +75,7 @@ public StringSubstrColStart() { * @param len length of the bytes the string holds in the byte array * @param substrStart the Start index for the substring operation */ - static int getSubstrStartOffset(byte[] utf8String, int start, int len, int substrStart) { + public static int getSubstrStartOffset(byte[] utf8String, int start, int len, int substrStart) { Review Comment: you can use package-private visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org