ayushtkn commented on code in PR #5821:
URL: https://github.com/apache/hive/pull/5821#discussion_r2161176648
##########
Jenkinsfile:
##########
@@ -226,7 +226,7 @@ jobWrappers {
$class: 'GitSCM',
branches: scm.branches,
doGenerateSubmoduleConfigurations:
scm.doGenerateSubmoduleConfigurations,
- extensions: scm.extensions,
+ extensions: [ cloneOption(honorRefspec: true, depth: 50, noTags:
true, shallow: true) ],
Review Comment:
It should be good in most cases.
@zabetak I have a small question, say in some rare scenrios like where we
chase major upgrades or so, like hadoop or jdk upgrade kind of places, where
the commits in PR can go beyond 50.
So, in that case does my build break?
& say if I force Push to reduce back the number down to 49 will it start
working, if later, I believe that should be mentioned somewhere in the PR
template or so.
If nothing breaks in such a scenario, I am good with this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
