ayushtkn commented on code in PR #5869:
URL: https://github.com/apache/hive/pull/5869#discussion_r2161074353
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -942,6 +942,9 @@ public enum ConfVars {
INIT_HOOKS("metastore.init.hooks", "hive.metastore.init.hooks", "",
"A comma separated list of hooks to be invoked at the beginning of
HMSHandler initialization. \n" +
"An init hook is specified as the name of Java class which extends
org.apache.riven.MetaStoreInitListener."),
+ INIT_METADATA_COUNT_ENABLED("metastore.initial.metadata.count.enabled",
+ "hive.metastore.initial.metadata.count.enabled", true,
+ "Enable a metadata count at metastore startup for metrics."),
Review Comment:
Sai, I checked the 3.x code, it was true then as well
https://github.com/apache/hive/blob/bdf3285bc250609c1b31a52e7732be8c043b8817/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L539-L541
& if you check the current code
```
if (Metrics.getRegistry() != null &&
MetastoreConf.getBoolVar(conf,
ConfVars.INIT_METADATA_COUNT_ENABLED)) {
```
earlier if ``Metrics.getRegistry() `` is not ``null`` this was always
enabled, but if set `false` as `default`, it won't preserve the old behaviour.
So, I think `true` as default is fine, we are just allowing an option to
disable this if they want, as of now it is always enabled.
Did I miss something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
