ngsg commented on PR #5771: URL: https://github.com/apache/hive/pull/5771#issuecomment-2995361536
@okumin, I introduced a new abstract class `NormalizedMetaStoreClient`, which eliminates nearly all overloaded method, following the approach you suggested. All `IMetaStoreClient` implementations, including ThriftHiveMetaStoreClient, now extend `NormalizedMetaStoreClient`, and much of the redundant logic for setting default catalog has been removed. Regarding your review comments that I haven't responded to directly, I believe this change addresses the issues raised in them. (The original review comment is [here](https://github.com/apache/hive/pull/5771#issuecomment-2882690936).) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
