ryukobayashi commented on code in PR #5624:
URL: https://github.com/apache/hive/pull/5624#discussion_r2162968713
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java:
##########
@@ -172,32 +170,69 @@ public BytesWritable evaluate(BytesWritable bw,
IntWritable pos, IntWritable len
}
private BytesWritable evaluateInternal(BytesWritable bw, int pos, int len) {
-
if (len <= 0) {
return new BytesWritable();
}
- int[] index = makeIndex(pos, len, bw.getLength());
- if (index == null) {
+ byte[] b = Arrays.copyOf(bw.getBytes(), bw.getLength());
Review Comment:
There was no need to copy. I fixed it.
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java:
##########
@@ -172,32 +170,69 @@ public BytesWritable evaluate(BytesWritable bw,
IntWritable pos, IntWritable len
}
private BytesWritable evaluateInternal(BytesWritable bw, int pos, int len) {
-
if (len <= 0) {
return new BytesWritable();
}
- int[] index = makeIndex(pos, len, bw.getLength());
- if (index == null) {
+ byte[] b = Arrays.copyOf(bw.getBytes(), bw.getLength());
+ StringSubstrColStartLen.populateSubstrOffsets(b, 0, b.length,
craetePos(pos), len, index);
+ if (index[0] == -1) {
return new BytesWritable();
}
- return new BytesWritable(Arrays.copyOfRange(bw.getBytes(), index[0],
index[1]));
+ return new BytesWritable(arrayCopy(b, index[0], index[1]));
+ }
+
+ private BytesWritable evaluateInternal(BytesWritable bw, int pos) {
+ byte[] b = Arrays.copyOf(bw.getBytes(), bw.getLength());
Review Comment:
There was no need to copy. I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
