dengzhhu653 commented on code in PR #5890:
URL: https://github.com/apache/hive/pull/5890#discussion_r2163364273
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlUpdatePart.java:
##########
@@ -473,15 +467,13 @@ private void setAnsiQuotes(Connection dbConn) throws
SQLException {
* @return map of partition key to column stats if successful, null
otherwise.
*/
public Map<String, Map<String, String>>
updatePartitionColumnStatistics(Map<String, ColumnStatistics> partColStatsMap,
- Table tbl, long csId,
+ Table tbl,
String validWriteIds,
long writeId,
List<TransactionalMetaStoreEventListener> transactionalListeners)
throws MetaException {
- Transaction tx = pm.currentTransaction();
Review Comment:
It's safe. I move the transaction open to ObjectStore, this method will be
executed under the transaction:
https://github.com/apache/hive/pull/5890/files#diff-ddc1cac0afb55312b1d426288dbb7c32611ea996d2224f1692f3a53134fd9a80R9699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
