rtrivedi12 commented on code in PR #5766: URL: https://github.com/apache/hive/pull/5766#discussion_r2163974228
########## ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/events/AlterPartitionEvent.java: ########## @@ -76,10 +76,15 @@ private List<HivePrivilegeObject> getOutputHObjs() { ret.add(getHivePrivilegeObject(event.getTable())); Partition newPartition = event.getNewPartition(); + Partition oldPartition = event.getOldPart(); Review Comment: @deniskuzZ Both Partition and Table objects in `PreAlterPartitionEvent` are thrift table and thrift partition and would need to be translated to org.apache.hadoop.hive.ql.metadata.Table and org.apache.hadoop.hive.ql.metadata.Partition. But I think this makes sense to avoid modification in PreAlterPartitionEvent and HMSHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org