harshal-16 commented on code in PR #5842: URL: https://github.com/apache/hive/pull/5842#discussion_r2166249335
########## ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/events/CommitTxnHandler.java: ########## @@ -128,6 +130,20 @@ private List<WriteEventInfo> getAllWriteEventInfo(Context withinContext) throws }))); } + private List<WriteEventInfo> getAllWriteEventInfoExceptMV(List<WriteEventInfo> writeEventInfoList) { Review Comment: It is required for https://github.com/apache/hive/commit/f82d780d6d5db116a19ebef846ce302d36cf2d4d As Materialised view is not supported by replication, we need a way to differentiate between insert and materialised view rebuild kind of event you can check the truth table in CommitTxnHandler in (https://github.com/apache/hive/commit/f82d780d6d5db116a19ebef846ce302d36cf2d4d#diff-d8c044001331ab3f52b23cf8ff3394a2b941c8848f7711e1d69f4b4cdd703cd9) We want to replay the commit for insert events but want to skip for the MV related events -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org