zabetak commented on code in PR #5897:
URL: https://github.com/apache/hive/pull/5897#discussion_r2166811761
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -128,6 +128,13 @@ public class MetastoreConf {
keyToVars.put(var.varname, var);
keyToVars.put(var.hiveName, var);
}
+ Configuration.addDeprecations(new Configuration.DeprecationDelta[] {
Review Comment:
We don't have a policy in place about when and how to remove deprecated
props so its our call. Personally, my goal here is to avoid the unnecessary
perf hit so I don't mind removing them completely if you prefer this path.
Most often, when projects follow semantic versioning breaking changes only
happen during major version bumps so ideally the removal should happen in 5.x.
In Hive, we are not so dogmatic about it so I think we can afford such small
breaking changes even in minor version bumps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
