zabetak commented on code in PR #5795:
URL: https://github.com/apache/hive/pull/5795#discussion_r2166848469


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInBetweenExpandRule.java:
##########
@@ -152,7 +153,7 @@ private RexInBetweenExpander(RexBuilder rexBuilder) {
     public RexNode visitCall(final RexCall call) {
       switch (call.getKind()) {
       case SEARCH: {
-        return new SearchTransformer<>(rexBuilder, 
call).transform().accept(this);
+        return new SearchTransformer<>(rexBuilder, call, 
RexUnknownAs.UNKNOWN).transform().accept(this);

Review Comment:
   The RexInBetweenExpander is also used for Project and Join operators so if 
we want to change the unknown context we should probably generalize a bit this 
class. Not sure if it will make a huge difference in the plans but I can try it 
out if you want.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to