zabetak commented on code in PR #5891:
URL: https://github.com/apache/hive/pull/5891#discussion_r2166879683


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUUIDV7.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.udf;
+
+import org.apache.hadoop.hive.ql.exec.Description;
+import org.apache.hadoop.hive.ql.exec.UDF;
+import org.apache.hadoop.io.Text;
+
+import java.util.UUID;
+import java.util.concurrent.ThreadLocalRandom;
+
+/**
+ * UDFUUIDV7.
+ *
+ */
+@Description(name = "uuid_v7",
+        value = "_FUNC_() - Returns a universally unique identifier (UUID_V7) 
string.",
+        extended = """
+                The value is returned as a canonical UUID 36-character string.
+                Example:
+                  > SELECT _FUNC_();
+                  '0baf1f52-53df-487f-8292-99a03716b688'
+                  > SELECT _FUNC_();
+                  '36718a53-84f5-45d6-8796-4f79983ad49d'""")
+@UDFType(deterministic = false)
+public class UDFUUIDV7 extends UDF {
+  private final Text result = new Text();
+  /**
+   * Returns a universally unique identifier (UUID_V7) string (36 characters).
+   *
+   * @return Text
+   */
+  public Text evaluate() {
+    result.set(randomUUIDV7().toString());
+    return result;
+  }
+
+
+  private UUID randomUUIDV7() {

Review Comment:
   It really depends if we are talking about adding a new dependency to a huge 
library or if we are adding a dependency with a single Java class. Copying code 
is not a good practice and has various disadvantages. 
   
   If for instance you copy the code in Hive then we cannot take advantage of 
improvements/bug fixes/security patches that will land in the dependent 
library. Nobody, will care to bring these changes to Hive and it may be too 
late when we realize that somethings is needed.
   
   Moreover, when you copy code from open-source projects and you have to 
follow the ASF policies (i.e., 
https://www.apache.org/legal/src-headers.html#3party) that I don't think you 
did in this case. This has legal implications that make our life more difficult.
   
   Dependencies come and go so its fine to add/remove things when it makes 
sense to do so.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to