deniskuzZ commented on PR #5637: URL: https://github.com/apache/hive/pull/5637#issuecomment-3005096961
> > > Do we have test coverage for all the affected datatypes (int, long, bigint, decimal, date, timestamp) ? > > > > > > I haven't changed the date & timestamp. Only int, bigint (represented as long) and decimal (see tpcds tests, more accurate row could estimation) existing q tests cover the intent of this PR > > The reason why I ask is that for exmaple timestap had > > ``` > long maxValue = cs.getRange().maxValue.longValue(); > long minValue = cs.getRange().minValue.longValue(); > ``` > > So the `minValue` was also `long`. In this patch it is `int`. @kasakrisz, please take a closer look: long was used for BIG_INT, not INT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
