deniskuzZ commented on PR #5893: URL: https://github.com/apache/hive/pull/5893#issuecomment-2999759522
> @deniskuzZ @zhangbutao Does this align with your expectations? If yes, I wonder if we will merge this before cutting the 4.1 branch. As good news, the current implementation worked with Trino 🥳 https://issues.apache.org/jira/browse/HIVE-28998?focusedCommentId=17985825&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17985825 Sorry folks, I was occupied with many other things and didn't have time to thing much about the API design. The change in the PR aligns with my original intent, though I began to question it after the discussion in https://github.com/apache/hive/pull/5870#discussion_r2158831458. ATM I am OK with either approach, though I’m leaning slightly toward the more generic one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
