ngsg commented on code in PR #5670:
URL: https://github.com/apache/hive/pull/5670#discussion_r2179018470
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/metainfo/annotation/OpTraitsRulesProcFactory.java:
##########
@@ -381,45 +381,82 @@ public Object process(Node nd, Stack<Node> stack,
NodeProcessorCtx procCtx,
public static class SelectRule implements SemanticNodeProcessor {
// For bucket columns
- // If all the columns match to the parent, put them in the bucket cols
+ // If the projected columns are compatible with the bucketing requirement,
put them in the bucket cols
// else, add empty list.
+ public void putConvertedColNamesForBucket(
Review Comment:
Would it be better to make it private as `getConvertedColNamesForSort`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
