abstractdog commented on PR #5880: URL: https://github.com/apache/hive/pull/5880#issuecomment-3026564340
PR looks good to me—I'm open to giving a +1. The only potentially debatable part is the precision change, which results in many q.out diffs. However, looking at the underlying Java change: 🔗 https://github.com/openjdk/jdk/pull/3402/files which was eventually committed here: 🔗 https://github.com/openjdk/jdk/commit/72bcf2aa03d53b0f68eb07a902575b4e8628d859 The fact that even Java’s golden files changed is pretty telling—so it is what it is. For the Hive release, we can note that this is due to [JDK-4511638](https://bugs.openjdk.org/browse/JDK-4511638). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
