deniskuzZ commented on code in PR #5917:
URL: https://github.com/apache/hive/pull/5917#discussion_r2180303137


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/ScheduledQueryAnalyzer.java:
##########
@@ -102,7 +115,8 @@ private ScheduledQuery  
fillScheduledQuery(ScheduledQueryMaintenanceRequestType
         schqStored.setNextExecutionIsSet(false);
         return composeOverlayObject(schqChanges, schqStored);
       } catch (TException e) {
-        throw new SemanticException("unable to get Scheduled query" + e);
+        LOG.error("Unable to find Scheduled query: " + 
schqChanges.getScheduleKey().getScheduleName(), e);

Review Comment:
   @Neer393, sorry, my bad. Can we pass `throwException` as it was before, 
similar to a `DropTableAnalyzer`   
   ````
   ScheduledQuery schq = fillScheduledQuery(type, parsedSchq, throwException);
   ````
   and then
   ````
   } catch (NoSuchObjectException e) {
       if (throwException) {
         throw new 
SemanticException(ErrorMsg.INVALID_SCHEDULED_QUERY.getMsg(schqChanges.getScheduleKey().getScheduleName()),
 e);
     }
   } catch (TException e) {
     throw new SemanticException(e.getMessage(), e);
   }
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to