okumin commented on code in PR #5624:
URL: https://github.com/apache/hive/pull/5624#discussion_r2180135938
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java:
##########
@@ -96,13 +98,12 @@ private Text evaluateInternal(Text t, int pos, int len) {
return r;
}
- String s = t.toString();
- int[] index = makeIndex(pos, len, s.length());
- if (index == null) {
+ StringSubstrColStartLen.populateSubstrOffsets(t.getBytes(), 0,
t.getLength(), adjustStartPos(pos), len, index);
+ if (index[0] == -1) {
return r;
}
- r.set(s.substring(index[0], index[1]));
+ r.set(new String(t.getBytes(), index[0], index[1],
StandardCharsets.UTF_8));
Review Comment:
Sorry. I found a better method to copy the utf8 binary. Could you use it? I
slightly remember an extra UTF8 codec can be a bottleneck.
https://github.com/apache/hadoop/blob/rel/release-3.4.1/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java#L265-L277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
