deniskuzZ commented on code in PR #5926:
URL: https://github.com/apache/hive/pull/5926#discussion_r2184945679
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -3977,10 +3977,9 @@ private void fireInsertEvent(Table tbl, Map<String,
String> partitionSpec, boole
InsertEventRequestData insertData = new InsertEventRequestData();
insertData.setReplace(replace);
data.setInsertData(insertData);
+ insertData.setFilesAdded(new ArrayList<String>());
Review Comment:
no need for an explicit type. also could you please move it 1 line higher,
so that initialization of insertData isn't scattered
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -3977,10 +3977,9 @@ private void fireInsertEvent(Table tbl, Map<String,
String> partitionSpec, boole
InsertEventRequestData insertData = new InsertEventRequestData();
insertData.setReplace(replace);
data.setInsertData(insertData);
+ insertData.setFilesAdded(new ArrayList<String>());
Review Comment:
no need for an explicit type.
also could you please move it 1 line higher, so that initialization of
insertData isn't scattered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
