Aggarwal-Raghav commented on code in PR #5885: URL: https://github.com/apache/hive/pull/5885#discussion_r2190350698
########## iceberg/iceberg-handler/src/test/resources/log4j.properties: ########## @@ -1,24 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I believe so. Here is my reasoning: 1. It is not refered in the iceberg module pom or in any other pom as well. 2. Looks like it came as part iceberg mr module (might be even lower iceberg version as well): https://github.com/apache/iceberg/blob/apache-iceberg-1.3.0/mr/src/test/resources/log4j.properties 3. the comment in the log4j.properties file: "# Configuration for modules which are using log4j v1 (e.g. Hive2, DataNucleus)" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
