deniskuzZ commented on code in PR #5946: URL: https://github.com/apache/hive/pull/5946#discussion_r2194582120
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ########## @@ -1154,42 +1155,21 @@ private boolean checkIfTableIsUsable(String tableName, boolean configValue) { } /** - * Returns the databases updated by txnId. - * Queries TXN_TO_WRITE_ID using txnId. + * Returns the TxnWriteDetails updated by txnIds. + * Queries TXN_TO_WRITE_ID using txnIds. * - * @param txnId - * @throws MetaException + * @param txnIds Transaction IDs for which write IDs are requested. + * @throws MetaException throws MetaException */ - private List<String> getTxnDbsUpdated(long txnId) throws MetaException { + public List<TxnWriteDetails> getWriteIdsMappingForTxns(List<Long> txnIds) throws MetaException { Review Comment: why change to public? i don't see any external usages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org