zhangbutao commented on code in PR #5951:
URL: https://github.com/apache/hive/pull/5951#discussion_r2197089723
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PersistenceManagerProvider.java:
##########
@@ -653,7 +653,6 @@ private static <T> T retry(Supplier<T> s) {
LOG.warn("Exception retry limit reached, not retrying any
longer.", e);
} else {
LOG.debug("Non-retriable exception.", e);
- break;
Review Comment:
BTW, Should we place `ex = e` before the` if else` block to ensure it
executes even if a break is encountered?
```
@@ -649,13 +649,13 @@ private static <T> T retry(Supplier<T> s) {
// If we're here, we'll proceed down the next while loop
iteration.
} else {
// we've reached our limit, throw the last one.
+ ex = e;
if (retriable) {
LOG.warn("Exception retry limit reached, not retrying any
longer.", e);
} else {
LOG.debug("Non-retriable exception.", e);
break;
}
- ex = e;
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
