Indhumathi27 commented on code in PR #5953:
URL: https://github.com/apache/hive/pull/5953#discussion_r2200176185
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java:
##########
@@ -574,10 +574,12 @@ public void addPartitionColsToBatch(ColumnVector col,
Object value, int colIndex
if (value == null) {
dv.noNulls = false;
dv.isNull[0] = true;
- dv.isRepeating = true;
} else {
- dv.fill(((HiveDecimal) value).longValue());
+ // fill serialized decimal value
+ dv.set(0, (HiveDecimal) value);
Review Comment:
there is no dv.fill implementation in Decimal64ColumnVector. Either i can
implement this in Decimal64ColumnVector or keep current changes. what do you
suggest @deniskuzZ ?
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java:
##########
@@ -574,10 +574,12 @@ public void addPartitionColsToBatch(ColumnVector col,
Object value, int colIndex
if (value == null) {
dv.noNulls = false;
dv.isNull[0] = true;
- dv.isRepeating = true;
} else {
- dv.fill(((HiveDecimal) value).longValue());
+ // fill serialized decimal value
+ dv.set(0, (HiveDecimal) value);
Review Comment:
there is no dv.fill() implementation in Decimal64ColumnVector. Either i can
implement this in Decimal64ColumnVector or keep current changes. what do you
suggest @deniskuzZ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
