deniskuzZ commented on code in PR #5959:
URL: https://github.com/apache/hive/pull/5959#discussion_r2200260617
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -815,8 +815,8 @@ private void assertFileFormat(String format) {
}
private void
setCommonHmsTablePropertiesForIceberg(org.apache.hadoop.hive.metastore.api.Table
hmsTable) {
- // If the table is not managed by Hive catalog then the location should be
set
- if (!Catalogs.hiveCatalog(conf, catalogProperties)) {
+ // If the table is not managed by Hive or Hadoop catalog, then the
location should be set
+ if (!Catalogs.hiveCatalog(conf, catalogProperties) &&
!Catalogs.hadoopCatalog(conf, catalogProperties)) {
Review Comment:
````
org.apache.hadoop.hive.ql.exec.tez.TezRuntimeException: Vertex failed,
vertexName=Map 1, vertexId=vertex_1752223623655_0001_3_00, diagnostics=[Vertex
vertex_1752223623655_0001_3_00 [Map 1] killed/failed due
to:ROOT_INPUT_INIT_FAILURE, Vertex Input: orders initializer failed,
vertex=vertex_1752223623655_0001_3_00 [Map 1], java.io.IOException: cannot find
dir = /tmp/default/orders in pathToPartitionInfo:
[file:/Users/dkuzmenko/projects/hive/upstream/hive/itests/qtest-iceberg/target/localfs/warehouse/orders]
````
try to delete: table dir should be pre-created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
