ayushtkn commented on code in PR #5968:
URL: https://github.com/apache/hive/pull/5968#discussion_r2203171230


##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -396,7 +396,10 @@ public void handle(Signal signal) {
 
           // First, kill any running MR jobs
           HadoopJobExecHelper.killRunningJobs();
-          TezJobExecHelper.killRunningJobs();
+          //when engine is not tez,it will throw ClassNotFoundException: 
org.apache.tez.dag.DAG

Review Comment:
   this comment isn't required



##########
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java:
##########
@@ -396,7 +396,10 @@ public void handle(Signal signal) {
 
           // First, kill any running MR jobs
           HadoopJobExecHelper.killRunningJobs();
-          TezJobExecHelper.killRunningJobs();
+          //when engine is not tez,it will throw ClassNotFoundException: 
org.apache.tez.dag.DAG
+          if ("tez".equalsIgnoreCase(conf.get("hive.execution.engine"))) {

Review Comment:
   Change it to
   ```
   "tez".equalsIgnoreCase(HiveConf.getVar(conf, 
HiveConf.ConfVars.HIVE_EXECUTION_ENGINE))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to