okumin commented on code in PR #5969:
URL: https://github.com/apache/hive/pull/5969#discussion_r2203235516
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java:
##########
@@ -49,6 +50,8 @@ public DataSource create(Configuration hdpConfig, int
maxPoolSize) throws SQLExc
String driverUrl = DataSourceProvider.getMetastoreJdbcDriverUrl(hdpConfig);
String user = DataSourceProvider.getMetastoreJdbcUser(hdpConfig);
String passwd = DataSourceProvider.getMetastoreJdbcPasswd(hdpConfig);
+ long maxLifeTime = MetastoreConf.getLongVar(hdpConfig,
+ MetastoreConf.ConfVars.METASTORE_HIKARICP_MAX_LIFE_TIME);
Review Comment:
No, we don't, need to have it, probably. Please see the discussion in this
PR and the test case I added.
https://github.com/apache/hive/pull/5639
https://github.com/apache/hive/pull/5639/files#diff-21013298e701863201669c0a08dce28bff302bca654dda0287b76cb344ae2c7a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
