abstractdog commented on code in PR #5973:
URL: https://github.com/apache/hive/pull/5973#discussion_r2204467072
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -14077,9 +14077,7 @@ ASTNode analyzeCreateTable(
storageFormat.setStorageHandler(defaultStorageHandler);
isUserStorageFormat = true;
}
-
- // CREATE TABLE is a DDL and yet it's not handled by
DDLSemanticAnalyzerFactory
- // FIXME: HIVE-28724
+
queryProperties.setQueryType(QueryProperties.QueryType.DDL);
Review Comment:
if the this patch works properly, this line is not needed anymore:
```
queryProperties.setQueryType(QueryProperties.QueryType.DDL);
```
and the correctness will be tested automatically here:
https://github.com/apache/hive/blob/f4ab76bf51859f8a2f4e929b2163bb891d17008f/ql/src/test/org/apache/hadoop/hive/ql/parse/TestSemanticAnalyzer.java#L391-L393
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableAnalyser.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.table.create;
+
+import org.apache.hadoop.hive.ql.QueryState;
+import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.DDLType;
+import org.apache.hadoop.hive.ql.parse.ASTNode;
+import org.apache.hadoop.hive.ql.parse.CalcitePlanner;
+import org.apache.hadoop.hive.ql.parse.HiveParser;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+
+@DDLType(types = HiveParser.TOK_CREATETABLE)
+public class CreateTableAnalyser extends CalcitePlanner {
+
+ public CreateTableAnalyser(QueryState queryState)
Review Comment:
It does look a bit odd that the new class doesn't extend anything.
I believe one of the key goals of decoupling the DDL analyzers is to offload
logic from the massive SemanticAnalyzer, e.g.
```
ASTNode analyzeCreateTable(
```
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableAnalyser.java:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.table.create;
+
+import org.apache.hadoop.hive.ql.QueryState;
+import org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.DDLType;
+import org.apache.hadoop.hive.ql.parse.ASTNode;
+import org.apache.hadoop.hive.ql.parse.CalcitePlanner;
+import org.apache.hadoop.hive.ql.parse.HiveParser;
+import org.apache.hadoop.hive.ql.parse.SemanticException;
+
+@DDLType(types = HiveParser.TOK_CREATETABLE)
+public class CreateTableAnalyser extends CalcitePlanner {
Review Comment:
nit: we tend to use the Analyzer instead of Analyser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
