deniskuzZ commented on code in PR #5919:
URL: https://github.com/apache/hive/pull/5919#discussion_r2206708183
##########
itests/util/src/main/java/org/apache/hadoop/hive/ql/qoption/QTestDatabaseHandler.java:
##########
@@ -82,52 +80,48 @@ AbstractExternalDB create() {
abstract AbstractExternalDB create();
}
- private final Map<DatabaseType, String> databaseToScript = new
EnumMap<>(DatabaseType.class);
+ private final String scriptsDir;
+ private final List<AbstractExternalDB> databases = new ArrayList<>();
Review Comment:
@zabetak, in the below example, we could try to init multiple schemas in the
same database
````
--!qt:database:mysql:qdb1:q_test_country_state_city_tables.sql
--!qt:database:mysql:qdb2:q_test_country_state_city_tables.sql
...
--!qt:database:mysql:qdb5:q_test_country_state_city_tables.sql
````
won't we try to init mysql db container 5 times
````
for (AbstractExternalDB db : databases) {
db.start();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
