deniskuzZ commented on code in PR #5976:
URL: https://github.com/apache/hive/pull/5976#discussion_r2210301930
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreChecker.java:
##########
@@ -444,7 +444,12 @@ void findUnknownPartitions(Table table, Set<Path>
missingPartDirs,
for (Path partPath : missingPartDirs) {
FileSystem fs = partPath.getFileSystem(conf);
String partitionName = getPartitionName(fs.makeQualified(tablePath),
- partPath, partColNames, partitionColToTypeMap);
+ partPath, partColNames, partitionColToTypeMap, conf);
+ if (partitionName == null) {
+ // Skip this partition if there is some issue in the partition
validation
+ LOG.warn("Skipping partition : " + partPath.getName());
+ continue;
+ }
LOG.debug("PartitionName: " + partitionName);
if (partitionName != null) {
Review Comment:
why check for null, if we skip the iteration when `partitionName == null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
