difin commented on code in PR #5957:
URL: https://github.com/apache/hive/pull/5957#discussion_r2211449921


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java:
##########
@@ -642,6 +642,7 @@ private void commitCompaction(Table table, Long snapshotId, 
long startTime, File
     if (snapshotId != null) {
       rewriteFiles.validateFromSnapshot(snapshotId);
     }
+    rewriteFiles.set(IcebergTableUtil.SNAPSHOT_SOURCE_PROP, 
IcebergTableUtil.SnapshotSource.COMPACTION.name());

Review Comment:
   Fixed, now filtering by Iceberg built-in property `DataOperations.REPLACE 
`to determine snapshots created by compaction.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to